Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression error #317 and add unit test #318

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

gtsoul-tech
Copy link
Collaborator

This pull request addresses the regression error reported in issue #317. The following changes have been made:

  1. Added a new unit test bug317 to verify the regression error.
  2. Reverted the change that caused the regression error.

Changes

  • Added a new unit test in rebar_tests.cpp to check for the regression error.
  • Reverted the change that caused the regression error.

Testing

The new unit test bug317 has been added to ensure that the regression error is fixed.

Issue

Fixes #317

Copy link

@markos markos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approved

@markos markos merged commit 4f09e78 into VectorCamp:develop Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctness regression on x86 architecture
2 participants