Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Endgame of LibClone #1045

Merged
merged 17 commits into from
Aug 18, 2024
Merged

✨ Endgame of LibClone #1045

merged 17 commits into from
Aug 18, 2024

Conversation

atarpara
Copy link
Collaborator

@atarpara atarpara commented Aug 18, 2024 •
edited
Loading

Description

Close #1044.

  • ERC1967I (with immutable args) 1 type
  • ERC1967I beacon proxy (with and without immutable args) 2 types
  • implementationOf(address)

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge snapshot?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@atarpara atarpara changed the title ✨ Add ERC1967I Immutable Args ✨ Endgame of LibClone Aug 18, 2024
@atarpara atarpara marked this pull request as ready for review August 18, 2024 13:19
Vectorized
Vectorized reviewed Aug 18, 2024
View reviewed changes
Copy link
Owner

@Vectorized Vectorized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very beautiful.

@Vectorized Vectorized merged commit 833785d into main Aug 18, 2024
9 checks passed
@Vectorized Vectorized deleted the libclone branch August 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vectorized Vectorized Vectorized left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ LibClone new functions
2 participants
@atarpara @Vectorized