Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Optimize LibSort #1067

Merged
merged 2 commits into from
Sep 9, 2024
Merged

⚡️ Optimize LibSort #1067

merged 2 commits into from
Sep 9, 2024

Conversation

Vectorized
Copy link
Owner

@Vectorized Vectorized commented Sep 9, 2024

Description

In EVM land, using the stack directly is often cheaper than emulating a stack.

Also added a clean(address[] memory a) utility function.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge snapshot?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link
Collaborator

@atarpara atarpara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Vectorized Vectorized merged commit 4957a67 into main Sep 9, 2024
9 checks passed
@Vectorized Vectorized deleted the libsort-opt branch September 9, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants