Adds some conditional examples for Ruby

[AaronV]

No description provided.

[AaronV]

@trevororeilly, can you take a look at this update, see if it looks good based on what we talked about?

[dkhan]

if do_something or some_conditions is too long I would avoid modifiers. For good example I would have something specific like:

a = 1 if b.present?

[AaronV]

Yes, I tried to capture the long-case in the first #bad example. Do you think think needs a better example?

[AaronV]

If you mean the "do_something" and "some_condition"... I'd like to keep those as general as possible. I'm modeling this change on someone else's style-guide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier which is very easy to read.

[trevororeilly]

Could maybe start by specifically allowing certain cases like the single-line return:

• Favor modifier if/unless usage when you have a simple single-line return statement.
• Avoid modifier if/unless usage at the end of a non-trivial statement or multi-line block.

[AaronV]

I think that is covered in the current PR?

[trevororeilly]

Right, was just thinking that you could avoid uncertainty around which situations are allowed if the rule is really specific.