Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some mentions to the removed --idp-jwt that was renamed to --external-jwt #518

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix some mentions to the removed --idp-jwt that was renamed to --external-jwt #518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0376078
fix some mentions to --idp-jwt (was renamed to --external-jwt)
maelvls Sep 9, 2024
5d4ebf8
Merge branch 'master' into flag-idp-jwt-fix
BeardedPrincess Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/vcert/validatorsCloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ func validateConnectionFlagsCloud(commandName string) error {
emailPresent := flags.email != ""

if tokenURLPresent && !jwtPresent {
return fmt.Errorf("missing jwt for service account authentication. Set the jwt using --idp-jwt flag")
return fmt.Errorf("missing jwt for service account authentication. Set the jwt using --external-jwt flag")
}

advice := "Use --token-url/--idp-jwt for authentication or --email for registration"
advice := "Use --token-url/--external-jwt for authentication or --email for registration"
if !svcAccountPresent && !emailPresent {
return fmt.Errorf("missing flags for Venafi Cloud Platform authentication. %s", advice)
}
Expand Down