Fix assigning new created customer to the order #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix assigning new created customer to the order
test FP: https://github.com/Vendic/koene/pull/192
Problem description:
current module is creating new customer account on
sales_model_service_quote_submit_beforeevent.Also in same observer it is setting new customer id to quote, so that it be saved to order also.
But customer id setting to order happens before
sales_model_service_quote_submit_beforeevent dispatched. Because of that, order was not getting customer id.Proposition:
I also noticed that it is setting "Not logged in" customer group in quote (with comment to make configuration for this)
I think it would be nice just to set default customer group in that place (from Stores -> Configuration -> Customers -> Customer Configuration -> Create New Account Options -> Default Group)
@Tjitse-E what do you think?