This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Rename translate function to translateValue #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrs
changed the title
|
I'm not going to merge this PR because the changes weren't made in the src directory. However, I will make the change. |
|
I change the name to |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of widely spreaded Angular Translate (https://github.com/angular-translate/angular-translate)
I suggest to rename translate function name to translateValue. Its a BC break but I think its necessary.
Now I cannot use angular-slider and angular-translate at the same time.
PS you need to update minificated version as well