Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nullReferenceException thrown when FileLinePositionSpan does not contain a path #289

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: nullReferenceException thrown when FileLinePositionSpan does not contain a path #289

merged 1 commit into from
Sep 11, 2024

Conversation

jasonwoods-7
Copy link
Contributor

FileLinePositionSpan.Path can be null when specifying null as the location param in the Diagnostic.Create method in a source generator.

@SimonCropp
Copy link
Member

@jasonwoods-7 awesome. thanks

@SimonCropp SimonCropp added this to the 2.4.2 milestone Sep 11, 2024
@SimonCropp SimonCropp merged commit 6e48be3 into VerifyTests:main Sep 11, 2024
3 checks passed
@jasonwoods-7 jasonwoods-7 deleted the fix/empty-file-line-pos branch September 11, 2024 20:43
@SimonCropp
Copy link
Member

sorry for the delay. will deploy now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants