Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded-hal to 1.0.0 #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AnyTimeTraveler
Copy link

Also updated other dependencies
Removed dev-dependency stm32f4xx-hal, due to incompatible embedded-hal version

Also updated other dependencies
Removed dev-dependency stm32f4xx-hal, due to incompatible embedded-hal version
@tommy-gilligan
Copy link

Thank you for this! I need it for a project I'm working on.

I think the CS parameter can be eliminated:
https://docs.rs/embedded-hal/1.0.0-rc.1/embedded_hal/spi/index.html#for-driver-authors

I think stm32f4xx-hal is needed to run the example. There is an embedded-hal-one feature on that crate that can be used for compatibility with 1.0.0.alpha-11. This is not rc1 but it is close, hopefully it is an indication that rc1 compatibility will be adopted by stm32f4xx in the near future.

stm32-rs/stm32f4xx-hal@ba2e937
stm32-rs/stm32f4xx-hal#686

@TheNitek
Copy link

Any chance to get this merged and released?

@AnyTimeTraveler AnyTimeTraveler changed the title Update embedded-hal to 1.0.0-rc.1 Update embedded-hal to 1.0.0 May 14, 2024
@AnyTimeTraveler
Copy link
Author

I couldn't test this version, but it does compile and I don't see any changes that should have broken compatibility.

I'd appreciate, if someone has the time to test this update.
@tommy-gilligan or @TheNitek maybe?

@tommy-gilligan
Copy link

tommy-gilligan commented May 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants