Feature: Implement experiment run name update functionality #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functionality to update the name of an experiment run by modifying the methods in FutureExperimentRunServiceImpl and FutureExperimentRunDAO classes. The changes permit the updating of the experiment run name in the database. This functionality was implemented in response to the need for modification of experiment run details after their creation. Also, optimized the import statements in FutureExperimentRunDAO class for better readability and maintenance.
backend/server/src/main/java/ai/verta/modeldb/experimentRun/FutureExperimentRunDAO.java
Outdated
Show resolved
Hide resolved
backend/server/src/main/java/ai/verta/modeldb/experimentRun/FutureExperimentRunDAO.java
Outdated
Show resolved
Hide resolved
Common Code Coverage
|
Backend Code Coverage
|
Implemented new methods updateModifiedTimestampV2 and updateVersionNumberV2 in FutureExperimentRunDAO for update operation of experiment run name. Refactored updateExperimentRunName method to use the new implementations. Optimal import statements also added as part of readability improvement. Aim is to provide efficient way of updating experiment run name after creation.
backend/server/src/main/java/ai/verta/modeldb/experimentRun/FutureExperimentRunDAO.java
Outdated
Show resolved
Hide resolved
|
needs a unit test, and simplify the update into a single sql update, and this should be fine |
added 2 commits
September 21, 2023 19:24
Added validation in FutureExperimentRunServiceImpl to ensure that the experiment run's name is not blank. An exception is thrown if a name argument isn't present when updating the experiment run's name. To ensure the proper implementation, added corresponding tests in ExperimentRunTest to verify correct results and the absence of any exceptions when the name is properly updated. Also tested the scenario when the name argument is missing.
Incremented the version number each time the name of the experiment run is updated. This enhancement was done to track the changes in the name over time. Removed unneeded methods `updateModifiedTimestampV2` and `updateVersionNumberV2` as the changes are handled within the `UPDATE` sql statement. Verified these changes in the `ExperimentRunTest` by asserting that the version number increases by one after a name update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to update the name of an experiment run by modifying the methods in FutureExperimentRunServiceImpl and FutureExperimentRunDAO classes. The changes permit the updating of the experiment run name in the database. This functionality was implemented in response to the need for modification of experiment run details after their creation. Also, optimized the import statements in FutureExperimentRunDAO class for better readability and maintenance.
Impact and Context
Risks and Area of Effect
Testing
Reverting