Added support for passing defines list to ispc rules, also added linu…

[parvit]

Part of the fix for Vertexwahn/rules_oidn#1

In this change the ispc_cc_library method is changed to receive an additional collection of strings that are joined in a series of define command line switches for the ispc binary.

eg.

1. passing ["OIDN_DNNL"] produces "-DOIDN_DNNL"
2. passing ["OIDN_DNNL","OIDN_FILTER_RT"] produces "-DOIDN_DNNL -DOIDN_FILTER_RT"

Included also "--target-os=linux" for simmetry with the other platform definitions.

[Vertexwahn]

@parvit Just seeing that the merge broke my unit test :( - would be nice if the defines would be optional and there would be a test, that makes sure defines work....

[parvit]

I can do that, but where exactly are the tests located? Il giorno gio 16 mar 2023 alle ore 00:13 Vertexwahn < ***@***.***> ha scritto:

…

@parvit <https://github.com/parvit> Just seeing that the merge broke my unit test :( - would be nice if the defines would be optional and there would be a test, that makes sure defines work.... — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWGJD4DIDHHG3BEZUJUKTZTW4JEJZANCNFSM6AAAAAAV4O3AM4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Vittorio Parrella* Software Developer ***@***.*** Naples, Italy

[Vertexwahn]

@parvit -> https://github.com/Vertexwahn/rules_ispc/tree/main/tests

[Vertexwahn]

@parvit

git clone https://github.com/Vertexwahn/rules_ispc.git
cd rules_ispc
cd tests
bazel build //square:main
bazel run //square:main

-> should be "green" == should compile without errors

[parvit]

Do i run those with "run" like the "//:example" target or is there some special bazel command to launch them as tests? Il giorno gio 16 mar 2023 alle ore 00:18 Vertexwahn < ***@***.***> ha scritto:

…

@parvit <https://github.com/parvit> -> https://github.com/Vertexwahn/rules_ispc/tree/main/tests — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWGJD4EDY5UGCZBSP4L6ZHDW4JE4RANCNFSM6AAAAAAV4O3AM4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Vittorio Parrella* Software Developer ***@***.*** Naples, Italy

[Vertexwahn]

@parvit It is not a test in the sense of a unit test - its a test in the sense of "does it compile without errors" - bazel run //square:main will run square demo - this does not have any defines - currently it will fail with errors since the defines argument is not provided
There should be also a second "demo" in the test folder that expect a define - just to make sure that handing over defines works currently and in the future

[parvit]

Hi, just pushed the test example and a little fix that flew under my nose. Let me know if it is in line with what you expected. V. Il giorno gio 16 mar 2023 alle ore 00:23 Vertexwahn < ***@***.***> ha scritto:

…

@parvit <https://github.com/parvit> It is not a test in the sense of a unit test - its a test in the sense of "does it compile without errors" - bazel run //square:main will run square demo - this does not have any defines - currently it will fail with errors since the defines argument is not provided — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWGJD4BXBWT45VBQVZQKER3W4JFO7ANCNFSM6AAAAAAV4O3AM4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Vittorio Parrella* Software Developer ***@***.*** Naples, Italy