Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test example #3

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Added test example #3

merged 2 commits into from
Mar 16, 2023

Conversation

parvit
Copy link

@parvit parvit commented Mar 15, 2023

Added test example and made defines parameter optional.

…dded working example of defines parameter in ispc file
@Vertexwahn
Copy link
Owner

@parvit All CI tests are failing :(

@Vertexwahn
Copy link
Owner

@parvit -D".join(defines) seems not to work if defines = []

@parvit
Copy link
Author

parvit commented Mar 16, 2023

Yeah it was a stupid mistake (it is pretty late around here :D )

@Vertexwahn Vertexwahn merged commit 294b45b into Vertexwahn:main Mar 16, 2023
@Vertexwahn
Copy link
Owner

@parvit Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants