Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: mock navigator provider parameters orders #14

Merged
merged 2 commits into from
Sep 9, 2021
Merged

refactor: mock navigator provider parameters orders #14

merged 2 commits into from
Sep 9, 2021

Conversation

JigneshWorld
Copy link
Contributor

follow lint rule - sort_child_properties_last

Fixed #13

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@JigneshWorld
fix: mock navigator provider param orders
1606865 
follow lint rule - sort_child_properties_last
jeroen-meijer
jeroen-meijer approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@jeroen-meijer jeroen-meijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, small but appreciated 😄

LGTM

@jeroen-meijer jeroen-meijer merged commit 7772a76 into VeryGoodOpenSource:main Sep 9, 2021
@jeroen-meijer
Copy link
Contributor

@felangel I'll do a PR with a version bump later today. Do you think a build number increase would do the trick (0.1.0+1), or would a patch update be better suited to this change (0.1.1)?

Also, could you do a pub upload afterwards?

@felangel
Copy link
Contributor

felangel commented Sep 9, 2021

@felangel I'll do a PR with a version bump later today. Do you think a build number increase would do the trick (0.1.0+1), or would a patch update be better suited to this change (0.1.1)?

Also, could you do a pub upload afterwards?

I think we can just do a patch and yup happy to upload 👍

@jeroen-meijer
Copy link
Contributor

@felangel Thanks, done! #15

@JigneshWorld JigneshWorld deleted the follow-sort_child_properties_last branch September 10, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orestesgaolin orestesgaolin orestesgaolin approved these changes

@jeroen-meijer jeroen-meijer jeroen-meijer approved these changes

@felangel felangel Awaiting requested review from felangel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: MockNavigatorProvider auto complete to support lint rule sort_child_properties_last
4 participants
@JigneshWorld @jeroen-meijer @felangel @orestesgaolin