fix!: Updates for Flutter 3.16.0/Dart 3.2

[Tregan]

Status

READY

Description

• MockNavigator constructor now contains initialCanPop (default false), which is used to stub Navigator.canPop() automatically; it can ofcourse be overridden afterwards by stubbing again
• Fixed _MockMaterialPageRoute.hackOverlays() by creating a _MockOverlayState class that allows overriding of OverlayState.mounted

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[tomarra]

If were making these changes, can we also get the pubspec updated to >= 3.16.0 just to make sure we don't run into other issues later on?

[rodrigobastosv]

Can we merge this? I can't update project Flutter version because of this.

Thanks a lot!

[Tregan]

Can we merge this? I can't update project Flutter version because of this.

Thanks a lot!

You can temporarily override your dependency:

  mockingjay:
    git: https://github.com/Tregan/mockingjay

[jeroen-meijer]

Is there a particular reason other than convenience that canPop is stubbed by default?

I'd rather have an error during my test telling me I haven't mocked that method, rather than looking for a default that's hard to find.

Other than that, I'm okay with the changes. Thanks for the contribution!

[Tregan]

Is there a particular reason other than convenience that canPop is stubbed by default?

I'd rather have an error during my test telling me I haven't mocked that method, rather than looking for a default that's hard to find.

Other than that, I'm okay with the changes. Thanks for the contribution!

Nope, just for convenience since it will have to be stubbed for every MockNavigator. I'll take it out and update the tests.
Maybe the docs hould be updated as well?

[jeroen-meijer]

Sounds good. If that's fixed then I think we're good to go on this one.

[alestiago]

LGTM! Thank you for the contribution 💙 !

We'll update the README and any other documentation in a separate Pull Request.