chore: Switch to new pprof configuration

Signed-off-by: Vincent Boutour <bob@vibioh.fr>

README.md

@@ -53,6 +53,7 @@ Usage of api:
   --okStatus          int       [http] Healthy HTTP Status code ${API_OK_STATUS} (default 204)
   --port              uint      [server] Listen port (0 to disable) ${API_PORT} (default 1080)
   --pprofAgent        string    [pprof] URL of the Datadog Trace Agent (e.g. http://datadog.observability:8126) ${API_PPROF_AGENT}
+  --pprofPort         int       [pprof] Port of the HTTP server (0 to disable) ${API_PPROF_PORT} (default 0)
   --readTimeout       duration  [server] Read Timeout ${API_READ_TIMEOUT} (default 5s)
   --shutdownTimeout   duration  [server] Shutdown Timeout ${API_SHUTDOWN_TIMEOUT} (default 10s)
   --telemetryRate     string    [telemetry] OpenTelemetry sample rate, 'always', 'never' or a float value ${API_TELEMETRY_RATE} (default "always")

cmd/goweb/api.go

@@ -2,10 +2,6 @@ package main
 
 import (
 	"context"
-	"fmt"
-	"net/http"
-
-	_ "net/http/pprof"
 
 	"github.com/ViBiOh/httputils/v4/pkg/alcotest"
 	"github.com/ViBiOh/httputils/v4/pkg/cors"
@@ -20,24 +16,19 @@ func main() {
 	config := newConfig()
 	alcotest.DoAndExit(config.alcotest)
 
-	go func() {
-		fmt.Println(http.ListenAndServe("localhost:9999", http.DefaultServeMux))
-	}()
-
 	ctx := context.Background()
 
-	client, err := newClient(ctx, config)
+	clients, err := newClient(ctx, config)
 	logger.FatalfOnErr(ctx, err, "client")
 
-	defer client.Close(ctx)
+	defer clients.Close(ctx)
+	go clients.Start()
 
 	appServer := server.New(config.appServer)
 
-	go client.pprof.Start(client.health.DoneCtx())
-
-	go appServer.Start(client.health.EndCtx(), httputils.Handler(newPort(config, client), client.health, recoverer.Middleware, client.telemetry.Middleware("http"), owasp.New(config.owasp).Middleware, cors.New(config.cors).Middleware))
+	go appServer.Start(clients.health.EndCtx(), httputils.Handler(newPort(config, clients), clients.health, recoverer.Middleware, clients.telemetry.Middleware("http"), owasp.New(config.owasp).Middleware, cors.New(config.cors).Middleware))
 
-	client.health.WaitForTermination(appServer.Done())
+	clients.health.WaitForTermination(appServer.Done())
 
 	server.GracefulWait(appServer.Done())
 }

cmd/goweb/client.go

@@ -39,6 +39,10 @@ func newClient(ctx context.Context, config configuration) (client, error) {
 	return output, nil
 }
 
+func (c client) Start() {
+	go c.pprof.Start(c.health.DoneCtx())
+}
+
 func (c client) Close(ctx context.Context) {
 	c.telemetry.Close(ctx)
 }

go.mod

@@ -6,7 +6,7 @@ toolchain go1.22.0
 
 require (
 	github.com/ViBiOh/flags v1.5.0
-	github.com/ViBiOh/httputils/v4 v4.75.1
+	github.com/ViBiOh/httputils/v4 v4.75.3
 	go.opentelemetry.io/otel/metric v1.26.0
 )
 

go.sum

@@ -1,7 +1,7 @@
 github.com/ViBiOh/flags v1.5.0 h1:nwuFS8tAwtV6rTPpv2pCB+r12WjZYLjluW7yT+SeVpQ=
 github.com/ViBiOh/flags v1.5.0/go.mod h1:39UMuTnKsIp6walgD8dK99KRCb4DJt9vPtbWehHh1T0=
-github.com/ViBiOh/httputils/v4 v4.75.1 h1:HPQ9zzs9qaNaXz7sbmqFFp+PQthnwHXElfI3Ii1JCB0=
-github.com/ViBiOh/httputils/v4 v4.75.1/go.mod h1:hjrxCv58B8RFGgGNjIOBXqnzoYL7De2IjC2AIMsRKWU=
+github.com/ViBiOh/httputils/v4 v4.75.3 h1:+weNBuOx5ApBZXZ/Ku5cVwfedThrvBh7ZpzV5lTDeHQ=
+github.com/ViBiOh/httputils/v4 v4.75.3/go.mod h1:hjrxCv58B8RFGgGNjIOBXqnzoYL7De2IjC2AIMsRKWU=
 github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=
 github.com/cenkalti/backoff/v4 v4.3.0/go.mod h1:Y3VNntkOUPxTVeUxJ/G5vcM//AlwfmyYozVcomhLiZE=
 github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=

infra/api.yaml

@@ -52,7 +52,5 @@ spec:
       API_PPROF_AGENT: http://datadog.observability:8126
       API_TELEMETRY_URL: datadog.observability:4317
       OTEL_RESOURCE_ATTRIBUTES: env=production,git.repository_url=github.com/ViBiOh/goweb
-    pprof:
-      enabled: true
     autoscaling:
       enabled: false