test(mock): Removing useless call to Finish

Signed-off-by: Vincent Boutour <bob@vibioh.fr>
ViBiOh · May 3, 2024 · 65587c7 · 65587c7
1 parent 84aa857
commit 65587c7
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 39 deletions.
diff --git a/pkg/middleware/middleware_test.go b/pkg/middleware/middleware_test.go
@@ -48,7 +48,6 @@ func TestMiddleware(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			userService := mocks.NewUserService(ctrl)
 			if intention == "simple" {

diff --git a/pkg/notifier/notifier_test.go b/pkg/notifier/notifier_test.go
@@ -118,7 +118,6 @@ func TestGetNewRepositoryReleases(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryService := mocks.NewRepositoryService(ctrl)
 
@@ -243,7 +242,6 @@ func TestGetKetchupToNotify(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockKetchupService := mocks.NewKetchupService(ctrl)
 
@@ -439,7 +437,6 @@ func TestSendNotification(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mailerService := mocks.NewMailer(ctrl)
 			testCase.instance.mailer = mailerService

diff --git a/pkg/notifier/releases_test.go b/pkg/notifier/releases_test.go
@@ -70,7 +70,6 @@ func TestGetNewStandardReleases(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryService := mocks.NewRepositoryService(ctrl)
 
@@ -185,7 +184,6 @@ func TestGetNewHelmReleases(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryService := mocks.NewRepositoryService(ctrl)
 			mockHelmProvider := mocks.NewHelmProvider(ctrl)

diff --git a/pkg/service/ketchup/ketchup_test.go b/pkg/service/ketchup/ketchup_test.go
@@ -54,7 +54,6 @@ func TestList(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockKetchupStore := mocks.NewKetchupStore(ctrl)
 
@@ -126,7 +125,6 @@ func TestListForRepositories(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockKetchupStore := mocks.NewKetchupStore(ctrl)
 
@@ -221,7 +219,6 @@ func TestCreate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockKetchupStore := mocks.NewKetchupStore(ctrl)
 			mockRepositoryService := mocks.NewRepositoryService(ctrl)
@@ -366,7 +363,6 @@ func TestUpdate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockKetchupStore := mocks.NewKetchupStore(ctrl)
 			mockRepositoryService := mocks.NewRepositoryService(ctrl)
@@ -505,7 +501,6 @@ func TestDelete(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockKetchupStore := mocks.NewKetchupStore(ctrl)
 
@@ -631,7 +626,6 @@ func TestCheck(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockKetchupStore := mocks.NewKetchupStore(ctrl)
 

diff --git a/pkg/service/repository/repository_test.go b/pkg/service/repository/repository_test.go
@@ -65,7 +65,6 @@ func TestList(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryStore := mocks.NewRepositoryStore(ctrl)
 
@@ -137,7 +136,6 @@ func TestSuggest(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryStore := mocks.NewRepositoryStore(ctrl)
 
@@ -264,7 +262,6 @@ func TestGetOrCreate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryStore := mocks.NewRepositoryStore(ctrl)
 			mockGithub := mocks.NewGenericProvider(ctrl)
@@ -381,7 +378,6 @@ func TestCreate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryStore := mocks.NewRepositoryStore(ctrl)
 			mockGithub := mocks.NewGenericProvider(ctrl)
@@ -489,7 +485,6 @@ func TestUpdate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryStore := mocks.NewRepositoryStore(ctrl)
 
@@ -582,7 +577,6 @@ func TestClean(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryStore := mocks.NewRepositoryStore(ctrl)
 
@@ -686,7 +680,6 @@ func TestCheck(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockRepositoryStore := mocks.NewRepositoryStore(ctrl)
 

diff --git a/pkg/service/user/user_test.go b/pkg/service/user/user_test.go
@@ -67,7 +67,6 @@ func TestStoreInContext(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockUserStore := mocks.NewUserStore(ctrl)
 			testCase.instance.store = mockUserStore
@@ -163,7 +162,6 @@ func TestCreate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			authService := mocks.NewAuthService(ctrl)
 			mockUserStore := mocks.NewUserStore(ctrl)
@@ -270,7 +268,6 @@ func TestCheck(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockUserStore := mocks.NewUserStore(ctrl)
 

diff --git a/pkg/store/ketchup/ketchup_test.go b/pkg/store/ketchup/ketchup_test.go
@@ -81,7 +81,6 @@ func TestList(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -220,7 +219,6 @@ func TestListByRepositoriesIDAndFrequencies(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -326,7 +324,6 @@ func TestGetByRepository(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -413,7 +410,6 @@ func TestCreate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -472,7 +468,6 @@ func TestUpdate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -525,7 +520,6 @@ func TestDelete(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 

diff --git a/pkg/store/repository/repository_test.go b/pkg/store/repository/repository_test.go
@@ -93,7 +93,6 @@ func TestList(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -238,7 +237,6 @@ func TestSuggest(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -362,7 +360,6 @@ func TestGet(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -491,7 +488,6 @@ func TestCreate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -581,7 +577,6 @@ func TestDeleteUnused(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -623,7 +618,6 @@ func TestDeleteUnusedVersions(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 

diff --git a/pkg/store/repository/repository_version_test.go b/pkg/store/repository/repository_version_test.go
@@ -79,7 +79,6 @@ func TestUpdateVersions(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 

diff --git a/pkg/store/user/user_test.go b/pkg/store/user/user_test.go
@@ -48,7 +48,6 @@ func TestGetByEmail(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -129,7 +128,6 @@ func TestGetByLoginID(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -207,7 +205,6 @@ func TestCreate(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)
 
@@ -253,7 +250,6 @@ func TestCount(t *testing.T) {
 			t.Parallel()
 
 			ctrl := gomock.NewController(t)
-			defer ctrl.Finish()
 
 			mockDatabase := mocks.NewDatabase(ctrl)