fix: Ignoring major version that looks like a date

Signed-off-by: Vincent Boutour <bob@vibioh.fr>
ViBiOh · Sep 7, 2021 · 89b4673 · 89b4673
1 parent 71b40e7
commit 89b4673
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/semver/semver.go b/pkg/semver/semver.go
@@ -101,6 +101,10 @@ func Parse(version string) (Version, error) {
 	}
 	var err error
 
+	if len(matches[1]) >= 8 {
+		return NoneVersion, fmt.Errorf("major version looks like a date: %s", version)
+	}
+
 	semver.major, err = strconv.ParseUint(matches[1], 10, 64)
 	if err != nil {
 		return NoneVersion, fmt.Errorf("version major is not numeric")

diff --git a/pkg/semver/semver_test.go b/pkg/semver/semver_test.go
@@ -269,6 +269,14 @@ func TestParse(t *testing.T) {
 			Version{"v1.2.3-abcdef123456", 1, 2, 3, 0},
 			nil,
 		},
+		{
+			"fucking date",
+			args{
+				version: "v20160726",
+			},
+			Version{},
+			errors.New("major version looks like a date"),
+		},
 	}
 
 	for _, tc := range cases {