Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent merges when styling does not pass #142

Closed
raingerber opened this issue Jan 11, 2018 · 1 comment
Closed

Prevent merges when styling does not pass #142

raingerber opened this issue Jan 11, 2018 · 1 comment
Labels
good first issue help wanted

Comments

@raingerber
Copy link
Contributor

raingerber commented Jan 11, 2018 •
edited by acatl
Loading

Problem description:

Branches that do not pass the prettier + standard linting can still be merged to master.

Suggested solution:

In addition to running our test suite, Travis should reject pull requests that still have formatting issues. This could be a script that runs prettier-standard, then runs git status and only approves the PR if no files have been changed.
@acatl acatl assigned acatl and unassigned acatl Jan 12, 2018
@acatl acatl changed the title Prevent merges when linting does not pass Prevent merges when styling does not pass Jan 12, 2018
@victorsingh
Copy link
Contributor

I'll give this one a try

victorsingh added a commit to victorsingh/data-point that referenced this issue Jan 30, 2018
@victorsingh
ci(.travis.yml): Added is-it-pretty bash script for travis-ci to chec…
de239f8 
…k if all *.js files in the proj

ViacomInc#142
@victorsingh victorsingh mentioned this issue Jan 30, 2018
Merged
5 tasks
victorsingh added a commit to victorsingh/data-point that referenced this issue Feb 1, 2018
@victorsingh
ci(scripts/is-it-pretty.sh): Added a detailed description on why trav…
a7b0147 
…is ci fails

ViacomInc#142
@acatl acatl closed this as completed in 55ce9d6 Feb 1, 2018
victorsingh pushed a commit to victorsingh/data-point that referenced this issue Feb 13, 2018
@victorsingh
ci(.travis.yml): check for unstyled files
3d1c52c 
Added is-it-pretty.sh script for travis-ci to check if there are files not passing prettier-standard

closes ViacomInc#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acatl @raingerber @victorsingh