feat(data-point-codemods): Add codemod for changing PathReducer from $. to $ #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmolluzzo
requested review from
acatl,
raingerber,
YiningChen and
abepeterkin
…ssing-root-path to get 100% cov re ViacomInc#179
…/data-point into add-codemod-for-pathreducer
raingerber
reviewed
Jan 25, 2018
| 'transform:d': '$', | ||
| 'transform:e': '$ | foo', | ||
| 'transform:f': '$ | $ | $', | ||
| 'transform:g': 'foo | bar | baz' |
There was a problem hiding this comment.
should we have any tests where the $. is nested inside some other kind of reducer?
// just for example
{
a: ['$.']
}There was a problem hiding this comment.
Sure, I can add that. Also something like dataPoint.transform('$. | foo', input) too?
raingerber
previously approved these changes
Jan 25, 2018
…-path-reducer-accessing-root-pa re: ViacomInc#179
…/data-point into add-codemod-for-pathreducer
paulmolluzzo
commented
Jan 25, 2018
| } | ||
| } | ||
|
|
||
| dataPoint.transform('foo | $. | baz | $.') |
There was a problem hiding this comment.
@raingerber Covering a few more scenarios.
There was a problem hiding this comment.
Wow. I overlooked this bug, pushed it, and then commented on it, and I still didn’t notice until the CI failed. 🤦♂️
acatl
approved these changes
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Adds a codemod to change
$.to$if found in a string or template literalWhy: Closes #179
How: http://http://astexplorer.net
Checklist: