Fix biomass missing cols #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have confirmed with a local rebuild and install with this updated source code that the |
jpshanno
reviewed
Jul 18, 2024
| DRYBIO_STUMP = DRYBIO_STUMP / adj, | ||
| DRYBIO_BG = DRYBIO_BG / adj, | ||
| DRYBIO_SAPLING = DRYBIO_SAPLING / adj, | ||
| DRYBIO_WDLD_SPP = DRYBIO_WDLD_SPP / adj, | ||
| DRYBIO_FOLIAGE = DRYBIO_WDLD_SPP / adj) |
There was a problem hiding this comment.
This looks like a bug in rFIA originally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
biomass_new.Randcarbon_new.Rto remove columns that no longer exist in FIA databases distributed by the USFS. This allows therFIA::biomassfunction to work as expected, but themodelSnagargument inrFIA::carbonnow has no effect. The elimination ofmodelSnagfunctionality could be restored if the pre-existing calculations were rewritten to draw from the columns that now exist in the FIA database (sinceSTANDING_DEADno longer exists, would need to derive it from FIA field TREE.CARBON_AG for dead trees only).