Skip to content

Commit

Permalink
include/asm-generic: Remove spin_is_locked() comment
Browse files Browse the repository at this point in the history
The WARN_ON_SMP() comment header suggests using spin_is_locked() to
check for locks being held.  But these days we prefer lockdep_assert_held(),
so this commit removes that suggestion.

Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arch@vger.kernel.org>
  • Loading branch information
Paul E. McKenney committed Jan 25, 2019
1 parent 7a968bb commit 728e3e6
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions include/asm-generic/bug.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,6 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
/*
* WARN_ON_SMP() is for cases that the warning is either
* meaningless for !SMP or may even cause failures.
* This is usually used for cases that we have
* WARN_ON(!spin_is_locked(&lock)) checks, as spin_is_locked()
* returns 0 for uniprocessor settings.
* It can also be used with values that are only defined
* on SMP:
*
Expand Down

0 comments on commit 728e3e6

Please sign in to comment.