Add poc of XDPLua #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lneto
reviewed
May 31, 2019
net/core/dev.c
Outdated
| @@ -4385,6 +4390,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb, | |||
| xdp->rxq = &rxqueue->xdp_rxq; | |||
|
|
|||
| act = bpf_prog_run_xdp(xdp_prog, xdp); | |||
| luaL_dostring(L, "print('hello wolrd')"); | |||
There was a problem hiding this comment.
can we think on a way to include a lua file statically here? perhaps using the C preprocessor.. btw, there's a typo above..
There was a problem hiding this comment.
at least, `#define LUA_SCRIPT "print('hello world')"
There was a problem hiding this comment.
I was previously using a macro for that, will change back
lneto
reviewed
May 31, 2019
| #include "lua.h" | ||
| #include "lauxlib.h" | ||
| #include "lualib.h" | ||
| #include "luadata.h" |
lneto
reviewed
May 31, 2019
| @@ -154,6 +158,7 @@ | |||
| /* This should be increased if a protocol with a bigger head is added. */ | |||
| #define GRO_MAX_HEAD (MAX_HEADER + 128) | |||
|
|
|||
| static lua_State *L; | |||
lneto
reviewed
May 31, 2019
net/core/dev.c
Outdated
| @@ -9816,6 +9824,9 @@ static int __init net_dev_init(void) | |||
|
|
|||
| BUG_ON(!dev_boot_phase); | |||
|
|
|||
| L = luaL_newstate(); | |||
| luaL_openlibs(L); | |||
| luaL_requiref(L, "data", luaopen_data, 1); | |||
lneto
reviewed
May 31, 2019
tammela
suggested changes
Jun 4, 2019
net/core/dev.c
Outdated
| @@ -9816,6 +9827,10 @@ static int __init net_dev_init(void) | |||
|
|
|||
| BUG_ON(!dev_boot_phase); | |||
|
|
|||
| L = luaL_newstate(); | |||
| luaL_openlibs(L); | |||
| luaL_requiref(L, "data", luaopen_data, 1); | |||
There was a problem hiding this comment.
not needed, you may use require() from the Lua scripts
VictorNogueiraRio
force-pushed
the
xdplua_poc
branch
from
e2a1b80 to
0834040
Compare
tammela
suggested changes
Jun 5, 2019
net/core/dev.c
Outdated
| @@ -9781,6 +9790,7 @@ static void __net_exit default_device_exit_batch(struct list_head *net_list) | |||
| * will run in the rtnl_unlock() at the end of | |||
| * default_device_exit_batch. | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
Yes, sorry about that. Will remove this in the next fix up
VictorNogueiraRio
force-pushed
the
xdplua_poc
branch
from
d0c1f8b to
b7e38c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.