Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: when modifying docs in place allow storing backups #3205

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

hagen1778
Copy link
Collaborator

The stored backups would help to identify docs corruption but aren't needed for commiting. So .tmp backup files are also git-ignored.

Signed-off-by: hagen1778 roman@victoriametrics.com

The stored backups would help to identify docs corruption
but aren't needed for commiting. So `.tmp` backup files
are also git-ignored.

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@hagen1778 hagen1778 requested a review from valyala October 6, 2022 11:21
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 57.68% // Head: 57.72% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (0606684) compared to base (ec04fca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3205      +/-   ##
==========================================
+ Coverage   57.68%   57.72%   +0.04%     
==========================================
  Files         285      285              
  Lines       48304    48304              
==========================================
+ Hits        27862    27884      +22     
+ Misses      18642    18624      -18     
+ Partials     1800     1796       -4     
Impacted Files Coverage Δ
lib/storage/storage.go 70.00% <0.00%> (+0.28%) ⬆️
app/vmselect/promql/aggr_incremental.go 87.68% <0.00%> (+1.20%) ⬆️
lib/mergeset/table.go 68.76% <0.00%> (+1.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valyala valyala merged commit 78af27f into master Oct 6, 2022
@valyala valyala deleted the docs-sync-cmd branch October 6, 2022 12:04
@valyala
Copy link
Collaborator

valyala commented Oct 6, 2022

@hagen1778 , thanks for the make docs-sync fix!

valyala pushed a commit that referenced this pull request Oct 6, 2022
The stored backups would help to identify docs corruption
but aren't needed for commiting. So `.tmp` backup files
are also git-ignored.

Signed-off-by: hagen1778 <roman@victoriametrics.com>

Signed-off-by: hagen1778 <roman@victoriametrics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants