Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setup-ruby's native bundle caching in our workflows #1937

Closed
boardfish opened this issue Dec 16, 2023 · 0 comments · Fixed by #1938
Closed

Use setup-ruby's native bundle caching in our workflows #1937

boardfish opened this issue Dec 16, 2023 · 0 comments · Fixed by #1938
Assignees
@boardfish

Comments

@boardfish
Copy link
Collaborator

While working on #1308, I've noticed that we use actions/cache where this is potentially avoidable. We may be able to use the setup-ruby action's bundler_cache option to leave that to the action instead of loading it ourselves.
@boardfish boardfish self-assigned this Dec 16, 2023
@boardfish boardfish mentioned this issue Dec 16, 2023
Merged
boardfish added a commit that referenced this issue Dec 17, 2023
@boardfish
Defer to built-in action caching
ec17074 
Closes #1937
@boardfish boardfish mentioned this issue Dec 17, 2023
Merged
boardfish added a commit that referenced this issue Aug 17, 2024
@boardfish
Defer to built-in action caching
b9ea9cd 
Closes #1937
boardfish added a commit that referenced this issue Aug 21, 2024
@boardfish
Defer to built-in action caching
7e65f68 
Closes #1937
boardfish added a commit that referenced this issue Aug 21, 2024
@boardfish
Defer to built-in action caching (#1938)
d090fb9 
* Defer to built-in action caching

Closes #1937

* Lookup PVC package-lock

* Setup Ruby in view_component directory

* Manually bundle check again before we run rake

* Update changelog

* Default to Ruby 3.3 for actions

* Remove version constraint for coverage

Uses the Rails version specified in Gemfile.lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boardfish boardfish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Defer to built-in action caching ViewComponent/view_component
1 participant
@boardfish