Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render_parent when variants are involved #1801

Merged
merged 17 commits into from
Jul 24, 2023
Merged

Fix render_parent when variants are involved #1801

merged 17 commits into from
Jul 24, 2023

Commits on Jul 13, 2023

  1. Fix render_parent when variants are involved

    @camertron
    camertron committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    8654142 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Ok, yield seems to work

    @camertron
    camertron committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    9b81c19 View commit details
    Browse the repository at this point in the history

  2. Got it working for variants and inline templates

    @camertron
    camertron committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7991f70 View commit details
    Browse the repository at this point in the history

  3. Refactor a bit

    @camertron
    camertron committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0bdd60c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Fix Vale grammar issues; add #render_parent test back in; fix linting… 

    … issues
    @camertron
    camertron committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4439760 View commit details
    Browse the repository at this point in the history

  2. Merge functionality instead

    @camertron
    camertron committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    fa6e672 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. wip

    @BlakeWilliams
    BlakeWilliams committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    d384cfe View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Fix tests

    @camertron
    camertron committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ecffaab View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Clean up

    @camertron
    camertron committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    314f75d View commit details
    Browse the repository at this point in the history

  2. Small fixes

    @camertron
    camertron committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1ff7b2d View commit details
    Browse the repository at this point in the history

  3. Merge upstream changes

    @camertron
    camertron committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1f5889b View commit details
    Browse the repository at this point in the history

  4. Update docs/api.md 

    Co-authored-by: Blake Williams <blakewilliams@github.com>
    @camertron @BlakeWilliams
    camertron and BlakeWilliams authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    d39e32f View commit details
    Browse the repository at this point in the history

  5. Fix linting issues

    @camertron
    camertron committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a701df5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'render_parent_with_variants' of github.com:ViewComponen… 

    …t/view_component into render_parent_with_variants
    @camertron
    camertron committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    656d883 View commit details
    Browse the repository at this point in the history

  7. Regen docs

    @camertron
    camertron committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    04f45c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Update lib/view_component/compiler.rb 

    Co-authored-by: Blake Williams <blakewilliams@github.com>
    @camertron @BlakeWilliams
    camertron and BlakeWilliams authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    5f2309e View commit details
    Browse the repository at this point in the history

  2. Add tests for rendering parents from inline templates (i.e. #call met… 

    …hods); add helpful #render_parent_to_string method
    @camertron
    camertron committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    11fdbcf View commit details
    Browse the repository at this point in the history