Stop running PVC's 'docs:preview' rake task in CI #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeWilliams
approved these changes
Aug 9, 2023
tgaff
pushed a commit
to tgaff/view_component
that referenced
this pull request
Aug 10, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
A recent PR removed the legacy docsite from the PVC repo, which included the
docs:previewrake task. We should stop running it in our CI.What approach did you choose and why?
I removed the line that runs the offending rake task.