Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable components to use @request and request methods/ivars #2135

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

joelhawksley
Copy link
Member

This replaces internal uses of request with __vc_request so any component that uses a request method or ivar will continue to work.

Closes #2111

This replaces internal uses of `request` with `__vc_request` so any
component that uses a request method or ivar will continue to work.
Copy link
Contributor

1 file(s) had their final line ending fixed:

  • test/sandbox/app/components/request_param_component.rb

Copy link
Contributor

1 file(s) had their final line ending fixed:

  • test/sandbox/app/components/request_param_component.rb

@joelhawksley joelhawksley merged commit d0576c1 into main Oct 16, 2024
8 checks passed
@joelhawksley joelhawksley deleted the bmw/request branch October 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not use "request" as argument
2 participants