Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of profiles #1042

Closed
1 task done
d-koppenhagen opened this issue Mar 22, 2024 · 3 comments · Fixed by #1043
Closed
1 task done

Inconsistent naming of profiles #1042

d-koppenhagen opened this issue Mar 22, 2024 · 3 comments · Fixed by #1043

Comments

@d-koppenhagen
Copy link
Contributor

The Control Profile is names "profile" and "profil" (without an "e") at some places.
The naming should be aligned.

  • Breaking Change
@Viglino
Copy link
Owner

Viglino commented Mar 22, 2024

There is a mix with profile (english) and profil (french)...
"profile" shoud be the rule...

@d-koppenhagen
Copy link
Contributor Author

yes! I can contribute and adjust ist but it will introduce a breaking change

Viglino added a commit that referenced this issue Mar 22, 2024
@Viglino
[UPD] Inconsistent naming of profiles #1042
1c1b8fe
@Viglino
Copy link
Owner

Viglino commented Mar 22, 2024

I've change the name to ol/control/Profile
ol.control.Profil style exists for backward compatibility.
The only breaking change is in the css ol-profil class...

d-koppenhagen added a commit to d-koppenhagen/ol-ext that referenced this issue Mar 22, 2024
@d-koppenhagen
refactor: change naming of profil to profile
de1ca1d 
BREAKING CHANGE: naming of `profil` has been changed to `profile` to hav a consistent language.
This results in possible breaking changes e. g. for some CSS classes which may be overridden for custom styling.

- `.ol-profilbar` is now `.ol-profilebar`
- `.ol-profilecursor` is now `.ol-profilecursor`
- `.ol-profilepopup` is now `.ol-profilepopup`
- `new Profil()` was removed, please use `new Profile()`

closes Viglino#1042
@d-koppenhagen d-koppenhagen mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: change naming of profil to profile d-koppenhagen/ol-ext
2 participants
@d-koppenhagen @Viglino