Fixes & Code Improvements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Modified code to ignore ALL key presses during the initial "Boot Sequence" loop. 2) Modified code to ignore INVALID key presses within the main loop. 3) Added code to avoid updating the timer prematurely within the initial & main loops due to repeatedly fast key presses. 4) Modified code to avoid redisplaying the top "Options Menu" unnecessarily too often and resetting the timer loop due to repeatedly fast key presses. 5) Modified code to get elapsed time percentage values with 1 decimal place (e.g. 0.5%) This allows displaying non-integer values for percentages of the elapsed time. 6) Modified top "Operations Menu" section with title for the "Setup Configuration Menu" to highlight "M" as the key press to launch the Setup Menu instead of "S" key press which was in conflict with the "S" required to *show* the "Operations Menu" section. 7) Fixed menu option to set "Timer Interval (seconds)" values because it was accepting any user input (e.g. "0", "X") with very little validation and there was no lower-bound & upper-bound value checking. For example, inputs like "0" && "X" were accepted leading to runtime errors being generated. 8) Various other coding improvements & fine-tuning.
Fine-tuning code.
Fine-tuning code around "Timer Reset" as a new "Next" or "Previous" page data is calculated and displayed.
Added a toggle switch to pause/resume the timer cycle within the main loop. Pressing the 'X' key (upper-case X only) will toggle the pause/resume state. While in a paused state, all character key presses are ignored except for the toggle 'X' key to resume the timer cycle.
|
Thanks for your work making this script even better, @Martinski4GitHub! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified code to ignore ALL character key presses during the initial "Boot Sequence" loop.
Modified code to ignore all INVALID character key presses within the main loop.
Added code to avoid updating the timer prematurely within the initial & main loops due to repeatedly fast key presses.
Modified code to avoid redisplaying the top "Options Menu" unnecessarily too often and resetting the timer loop due to repeatedly fast key presses.
Modified code to get elapsed time percentage values with 1 decimal place (e.g. 0.5%).
This allows non-integer values to be displayed for percentages of the elapsed time.
Modified the top "Operations Menu" section with the title for the "Setup Configuration Menu" to highlight "M" as the key press to launch the Setup Menu instead of the "S" key press which was in conflict with the "S" required to show the "Operations Menu" section.
Fixed menu option to set "Timer Interval (seconds)" values because it was accepting any user input (e.g. "0", "X") with very little validation and there was no lower-bound & upper-bound value checking.
For example, inputs like "0" && "X" were accepted leading to runtime errors being generated.
Added a toggle switch to pause/resume the timer cycle within the main loop.
Pressing the character 'X' key (upper-case X only) will toggle the timer to pause/resume. While in the paused state, all character key presses are ignored except for the toggle 'X' key to resume the timer.
Various other coding improvements & fine-tuning.