Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary requirements of mutable objects in many procs #10

Closed
Vindaar opened this issue Mar 18, 2018 · 2 comments
Closed

remove unnecessary requirements of mutable objects in many procs #10

Vindaar opened this issue Mar 18, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@Vindaar
Copy link
Owner

Vindaar commented Mar 18, 2018

Many procs still require a mutable object as their first argument, although in quite a few places that is not strictly necessary.

Needs to be cleaned up and some procs need a better separation between state changing parts and pure parts.

@Vindaar Vindaar changed the title remove un eccessary remove unnecessary requirements of mutable objects in many procs Mar 18, 2018
@Vindaar Vindaar added the enhancement New feature or request label Aug 28, 2018
@Vindaar
Copy link
Owner Author

Vindaar commented Dec 19, 2018

One possible solution to this whole problem would be a change of objects to reference objects.

@Vindaar
Copy link
Owner Author

Vindaar commented Nov 17, 2019

In #32 all objects are finally made ref objects. From here only procs which internally call visit_file will require a var argument.
For that proc it's debatable, whether it's required - the H5FileObj is given as a raw pointer to the C library in addition to a Nim callback. We could probably get away with unsafeAddr here too.

@Vindaar Vindaar closed this as completed Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant