Update attributes.nim #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move `contains` declaration before `let attr_exists = name in h5attr` because declaration order matters when calling ` h5f.attrs["foo", T]` from inside a generic procedure
|
Thanks! The next release (later today) includes a refactor of the attributes data writing. Part of that is support for more complex attribute types. Just mentioning it, because maybe you stumbled over certain types not being supported as attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move
containsdeclaration beforelet attr_exists = name in h5attrbecause declaration order matters when callingh5f.attrs["foo", T]from inside a generic procedure