Refactor attributes logic #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the attributes reading and writing logic. It brings it more in line with the dataset reading and writing logic.
In the future we might fully merge the two and take an argument for the correct HDF5 procedures to call. Meaning that the exact same logic is used to determine the way to prepare the data / convert it to Nim data from given HD5 data.
In addition this enhances the support for more complicated types supported in attributes. Also, all attributes and dataset types can now be read as JSON.
NOTE: For Nim versions below 2.0 it is advised to run with ORC. Otherwise you might get into trouble, due to bad destructor calls (some resources may be closed too early). Generally, while I'm not dropping support for 1.6 fully, it is definitely wonky. Test
tWithDsetends up in some weird loop in the compiler on 1.6.18. So please just upgrade...