Skip to content

VCST-1993: Add localization #58

VCST-1993: Add localization

VCST-1993: Add localization #58

Triggered via pull request October 21, 2024 09:55
Status Success
Total duration 2m 16s
Artifacts

module-ci.yml

on: pull_request
module-katalon-tests  /  e2e-tests
module-katalon-tests / e2e-tests
Matrix: deploy-cloud / Deploy
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/ModuleConstants.cs(9,18): warning S1118: Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/VirtoCommerce.TaxModule.Core.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/ModuleConstants.cs(23,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/VirtoCommerce.TaxModule.Core.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/ModuleConstants.cs(42,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/VirtoCommerce.TaxModule.Core.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/ModuleConstants.cs(34,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/VirtoCommerce.TaxModule.Core.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/ModuleConstants.cs(15,49): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/VirtoCommerce.TaxModule.Core.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/ModuleConstants.cs(15,49): warning S2223: Change the visibility of 'TaxTypes' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/VirtoCommerce.TaxModule.Core.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/ModuleConstants.cs(34,49): warning S2223: Change the visibility of 'FixedTaxRateProviderRate' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Core/VirtoCommerce.TaxModule.Core.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Data/Model/StoreTaxProviderEntity.cs(34,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Data/VirtoCommerce.TaxModule.Data.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Data/Model/StoreTaxProviderEntity.cs(64,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Data/VirtoCommerce.TaxModule.Data.csproj]
ci
/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Data/Model/StoreTaxProviderEntity.cs(48,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-tax/vc-module-tax/src/VirtoCommerce.TaxModule.Data/VirtoCommerce.TaxModule.Data.csproj]
ci
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/