Skip to content

VCST-1352: add XCatalog module #4

VCST-1352: add XCatalog module

VCST-1352: add XCatalog module #4

Triggered via pull request July 10, 2024 10:27
Status Success
Total duration 2m 18s
Artifacts

module-ci.yml

on: pull_request
module-katalon-tests  /  e2e-tests
module-katalon-tests / e2e-tests
Matrix: deploy-cloud / Deploy
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Schemas/ProductType.cs(310,193): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Schemas/PropertyType.cs(49,13): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Schemas/PropertyType.cs(87,13): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/ModuleConstants.cs(3,18): warning S1118: Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Models/ExpProductResponseGroup.cs(6,17): warning S2342: Rename this enumeration to match the regular expression: '^([A-Z]{1,3}[a-z0-9]+)*([A-Z]{2})?s$'. (https://rules.sonarsource.com/csharp/RSPEC-2342) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Specifications/CatalogProductIsBuyableSpecification.cs(17,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Queries/SearchProductQuery.cs(70,85): warning S109: Assign this magic number '20' to a well-named variable or constant, and use that instead. (https://rules.sonarsource.com/csharp/RSPEC-109) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Extensions/RewardExtensions.cs(14,28): warning S3776: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Extensions/RewardExtensions.cs(60,25): warning S134: Refactor this code to not nest more than 3 control flow statements. (https://rules.sonarsource.com/csharp/RSPEC-134) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]
ci
/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/Models/ExpProduct.cs(110,29): warning S3776: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776) [/home/runner/work/vc-module-x-catalog/vc-module-x-catalog/src/VirtoCommerce.XCatalog.Core/VirtoCommerce.XCatalog.Core.csproj]