Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCST-2009: single value variations fix #18

Merged
merged 3 commits into from
Oct 23, 2024
Merged

VCST-2009: single value variations fix #18

merged 3 commits into from
Oct 23, 2024

Conversation

ksavosteev
Copy link
Collaborator

@ksavosteev ksavosteev commented Oct 17, 2024 •
edited by vc-ci
Loading

Description

  1. Set Lucene search provider
  2. Add a product with a single variation
  3. Index the product
  4. _variations in the index document will look like this (string instead of an array of string):
    image
  5. Expected result:
    image
  6. Actual result: no variations returned

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-2009

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.XCatalog_3.816.0-pr-18-b386.zip

AhmedElrakhawy and others added 2 commits October 17, 2024 11:08
@AhmedElrakhawy @ksavosteev
a single variation not return issue fixed
d098eb6 
VariationBinder was not return the variation id if it was a single value
@ksavosteev
fix: refactor
acd8e7f
@ksavosteev ksavosteev mentioned this pull request Oct 17, 2024
Closed
vc-ci
vc-ci reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.012
Timestamp: 17-10-2024T09:44:01

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vc-ci
vc-ci reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.03
Timestamp: 23-10-2024T17:06:46

@ekuvirto ekuvirto merged commit 9af4dd4 into dev Oct 23, 2024
5 checks passed
@ekuvirto ekuvirto deleted the fix/VCST-2009-single-variation branch October 23, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vc-ci vc-ci vc-ci left review comments

@artem-dudarev artem-dudarev artem-dudarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ksavosteev @artem-dudarev @vc-ci @ekuvirto @AhmedElrakhawy