Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--noconf #96

Closed
ser opened this issue Aug 15, 2020 · 1 comment
Closed

--noconf #96

ser opened this issue Aug 15, 2020 · 1 comment
Labels
enhancement

Comments

@ser
Copy link
Contributor

ser commented Aug 15, 2020 •
edited
Loading

Currently the script forces configuration of nginx. There are use cases when configuration is maintained by ansible or other devops tools. It would be fantastic if an option --noconf exists where the parts of the script which are responsible for nginx configuration are simply omitted. Just build, install and forget.

I can try to prepare a PR if the idea is accepted.
@VirtuBox
Copy link
Owner

Hello @ser,
that's an excellent suggestion. Feel free to open a PR and I will merge it.
Thanks for your contribution.

@ser ser mentioned this issue Aug 24, 2020
Merged
VirtuBox added a commit that referenced this issue Sep 9, 2020
@VirtuBox
Merge pull request #99 from ser/master
f6d319c 
Allow omitting configuration, resolves #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ser @VirtuBox