Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resetting field #124

Merged
merged 4 commits into from
Aug 25, 2022
Merged

feat: resetting field #124

merged 4 commits into from
Aug 25, 2022

Conversation

mixvar
Copy link
Collaborator

@mixvar mixvar commented Aug 14, 2022

@mixvar mixvar force-pushed the feat/resetting-field branch from 760b906 to e08226b Compare August 14, 2022 21:41
@mixvar mixvar marked this pull request as ready for review August 14, 2022 23:25
@mixvar mixvar requested a review from pidkopajo August 14, 2022 23:25
@@ -18,6 +19,7 @@ export const getInitialState = <Values extends object, Err>({
const touched = makeUntouchedValues(values);

return {
initialValues: Atom.of(values),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a point in making atom out of initial values, since it's not going to be changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, nice catch!

@pidkopajo pidkopajo added the VB label Aug 22, 2022
@mixvar mixvar merged commit 47bc79d into master Aug 25, 2022
@mixvar mixvar deleted the feat/resetting-field branch August 25, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add FieldHandle.reset method
2 participants