Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: field handle isValidating flag #26

Merged
merged 4 commits into from
Oct 30, 2020
Merged

feat: field handle isValidating flag #26

merged 4 commits into from
Oct 30, 2020

Conversation

mixvar
Copy link
Collaborator

@mixvar mixvar commented Oct 27, 2020 •
edited
Loading

  • perf: smarter resolveIsValid impl
  • fix(core): clear errors of corresponding array items when shrinking array
  • refactor(validation): use named params in validate; promise based impl instead of async/await
  • feat(validation): keep track of validation start and end for each field
  • feat(core): keep track of validating state of each field

closes #24

@mixvar mixvar requested a review from pidkopajo October 27, 2020 00:01
@mixvar mixvar changed the title Feat/field handle is validating feat: field handle isValidating flag Oct 27, 2020
@mixvar mixvar merged commit e299289 into master Oct 30, 2020
@mixvar mixvar deleted the feat/field-handle-is-validating branch October 30, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pidkopajo pidkopajo pidkopajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] implement isValidating flag for each field
2 participants
@mixvar @pidkopajo