feat(core): form schema creator #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 20, 2020 23:32
- make surre error at compile time is thrown by TS for empty choice field - throw error at run time too - fix JSDoc not appearing
pidkopajo
approved these changes
Sep 27, 2020
| * })); | ||
| * ``` | ||
| */ | ||
| export const string = (): FieldDecoder<string> => { |
There was a problem hiding this comment.
a general note, wdyt of adding optional initial param to decoders? that will put the responsibility of form state initialization(or reset) to decoders only.
There was a problem hiding this comment.
I am not convinced this will work - with the currently planned approach decoders and schema need to work in static way - as top level export, while initial values may be dynamic and depend on e.g. component props
- change array path format - choice decoder: better signature - choice decoder: remvoe runtime input assertion - choice decoder: more performant implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4
FieldDecodertypeFieldDescriptortypeFormSchematypebool,string,number,choice,instanceOf,arraycreateFormSchemaimplementationsee
.specfiles for details