Make main class optional in preamble-less assemblies #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to generate assemblies with 'scala-cli package --assembly --preamble=false' even when no main class is defined. This can be handy to make assemblies that are not meant to be run as is, but are passed to other tools (such as proguard).
alexarchambault
force-pushed
the
allow-no-main-class-assemblies
branch
from
13316f1
to
82c20bf
Compare
Gedochao
reviewed
Jul 26, 2022
modules/cli-options/src/main/scala/scala/cli/commands/PackageOptions.scala
Show resolved
Hide resolved
Gedochao
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow one to generate an assembly, even for code that has no main class, when
--preamble=falseis passed. This can be useful for libraries, if users want to pass the assembly to tools such as proguard. This also accepts a (hidden)--main-class-in-manifest=falseoption if users want not only no preamble, but also no mention of main class in the assembly manifest (META-INF/MANIFEST.MFin the assembly JAR). The latter option is useful for tools, such as thehadoop jarcommand, that behave differently depending on the presence or not of a main class in the manifest.