Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define output option for package command with using directives #1213

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Define output option for package command with using directives #1213

merged 1 commit into from
Aug 1, 2022

Conversation

wleczny
Copy link
Contributor

@wleczny wleczny commented Jul 28, 2022

No description provided.

@wleczny wleczny requested a review from lwronski July 28, 2022 21:20
@wleczny wleczny linked an issue Jul 29, 2022 that may be closed by this pull request
--output option for package command in using directives #1210
Closed
lwronski
lwronski reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suggest only to add a documentation.

@wleczny wleczny force-pushed the output-option-for-using-directives branch 3 times, most recently from 2d111ad to 5d94ea7 Compare August 1, 2022 08:18
@wleczny wleczny marked this pull request as ready for review August 1, 2022 08:19
@wleczny wleczny added the enhancement New feature or request label Aug 1, 2022
Gedochao
Gedochao reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some language nitpick comments on the docs, otherwise LGTM

website/docs/commands/package.md Outdated Show resolved Hide resolved
website/docs/commands/package.md Outdated Show resolved Hide resolved
website/docs/commands/package.md Outdated Show resolved Hide resolved
website/docs/commands/package.md Outdated Show resolved Hide resolved
@wleczny wleczny force-pushed the output-option-for-using-directives branch from 5d94ea7 to 7f9b020 Compare August 1, 2022 09:01
@wleczny wleczny merged commit cad549f into VirtusLab:main Aug 1, 2022
@wleczny wleczny deleted the output-option-for-using-directives branch August 1, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackAnubis7 BlackAnubis7 BlackAnubis7 left review comments

@lwronski lwronski lwronski approved these changes

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--output option for package command in using directives
4 participants
@wleczny @Gedochao @BlackAnubis7 @lwronski