Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org name to VirtusLab for downloading scalafmt-native-image #1253

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Aug 16, 2022

scalafmt-native-image is now downloaded from virtuslab organisation. Native launcher is built in fork scalafmt-native-image

@lwronski lwronski marked this pull request as ready for review August 16, 2022 11:38
@lwronski lwronski changed the title Update org name for downloading scalafmt-native-image Update org name to VirtusLab for downloading scalafmt-native-image Aug 16, 2022
@lwronski
Copy link
Contributor Author

The docs-tests is failed, because we use there latest stable scala-cli version, which already trying to download scalafmt-native-image with the wrong URL.

IMO we can merge it and disable check if CI docs-tests is passed. After release, we enable again it.

@@ -12,7 +12,7 @@ object FmtOptionsUtil {
val osArchSuffix0 = osArchSuffix.map(_.trim).filter(_.nonEmpty)
.getOrElse(FetchExternalBinary.platformSuffix())
val tag0 = scalafmtTag.getOrElse("v" + version)
val gitHubOrgName0 = scalafmtGithubOrgName.getOrElse("alexarchambault/scalafmt-native-image")
val gitHubOrgName0 = scalafmtGithubOrgName.getOrElse("virtuslab/scalafmt-native-image")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still use the former URL, for versions lower than 3.5.9. Unless these versions' artifacts can be copied over to the new repository too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any way, how to copy artifacts from old repository to new

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you'd need to write a script to do it (using the GitHub API to create releases and upload things to the new repo).

@lwronski lwronski merged commit ad7782e into VirtusLab:main Aug 17, 2022
@lwronski lwronski added internal Internal or build-related changes bug Something isn't working labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Internal or build-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants