Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to the repl sub-command when no args are passed #1305

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

Gedochao
Copy link
Contributor

Fixes #1304
Fixes #1249

@Gedochao Gedochao force-pushed the no-arg-default-to-repl branch from 682a325 to 1bc4a34 Compare August 29, 2022 15:15
@Gedochao Gedochao marked this pull request as draft August 30, 2022 06:04
@Gedochao Gedochao force-pushed the no-arg-default-to-repl branch 2 times, most recently from 76fad17 to 29b4583 Compare August 30, 2022 10:00
@Gedochao Gedochao marked this pull request as ready for review August 30, 2022 11:49
@Gedochao Gedochao requested review from lwronski and wleczny August 30, 2022 11:50
Copy link
Contributor

@wleczny wleczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wleczny wleczny self-requested a review August 30, 2022 15:00
@Gedochao Gedochao force-pushed the no-arg-default-to-repl branch from 29b4583 to 6b342f5 Compare August 31, 2022 07:14
@Gedochao Gedochao merged commit 6c1367f into VirtusLab:main Aug 31, 2022
@Gedochao Gedochao deleted the no-arg-default-to-repl branch August 31, 2022 08:25
@Gedochao Gedochao added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
2 participants