Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run --python work with virtualenv for Scala Native #1399

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

kiendang
Copy link
Contributor

Make run --python work inside virtualenv for Scala Native by setting the SCALAPY_PYTHON_PROGRAMNAME to the path to the Python interpreter. This already works for JVM. For more details see #1270 (comment) and scalapy/scalapy#200.

Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kiendang!

Wondering if there would be a way to add non-regression tests for that… (likely in RunTestDefinitions) Maybe we could setup Python the same way ScalaPy does on its CI?

@kiendang
Copy link
Contributor Author

Currently virtualenv test in ScalaPy is WIP, part of scalapy/scalapy#303. I'm still not sure what's the best way to do this. The way I used to do it is to

  • create a venv
  • install a dummy package into a venv
  • activate the venv
  • test if scalapy can import the package

something like this script https://github.com/scalapy/sbt-scalapy/blob/e8bb194d8277ccb60b6b42545be047702c7380db/scripts/virtualenv_test.sh
I'm not sure if we can do something like that here.

@alexarchambault
Copy link
Contributor

Merging this so that it's part of 0.1.16. We can always add non regression tests for it later…

@alexarchambault alexarchambault merged commit 1ea18c8 into VirtusLab:main Oct 14, 2022
@kiendang kiendang deleted the run-python-venv-native branch October 14, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants