Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cli-options module #1552

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Remove cli-options module #1552

merged 4 commits into from
Nov 18, 2022

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault changed the title Remove cli options module Remove cli-options module Nov 8, 2022
@alexarchambault alexarchambault force-pushed the remove-cli-options-module branch 2 times, most recently from f78e4aa to 1e9c144 Compare November 9, 2022 09:35
@alexarchambault alexarchambault mentioned this pull request Nov 9, 2022
Merged
@alexarchambault alexarchambault force-pushed the remove-cli-options-module branch 3 times, most recently from 3794503 to 037dece Compare November 10, 2022 16:31
@alexarchambault alexarchambault force-pushed the remove-cli-options-module branch 4 times, most recently from 0154701 to 07577df Compare November 17, 2022 09:03
@alexarchambault alexarchambault marked this pull request as ready for review November 17, 2022 09:03
Gedochao
Gedochao approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but:

  • NIT: middle commit needs a better message or a NIT descriptor
  • SharedOptions is a huge source file now, might be worth a look later (but not in this PR)
  • great work tidying all this up, btw

@alexarchambault alexarchambault merged commit 30680c2 into VirtusLab:main Nov 18, 2022
@alexarchambault alexarchambault deleted the remove-cli-options-module branch November 18, 2022 15:07
@Gedochao Gedochao added the internal Internal or build-related changes label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@romanowski romanowski romanowski approved these changes

Assignees
No one assigned
Labels
internal Internal or build-related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexarchambault @romanowski @Gedochao