Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for running .md files inside of zipped archives #1581

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Add support for running .md files inside of zipped archives #1581

merged 2 commits into from
Nov 15, 2022

Conversation

Gedochao
Copy link
Contributor

Fixes #1514

Note that this simultanously adds the support for running markdown from GitHub Gists:

▶ scala-cli https://gist.github.com/Gedochao/6415211eeb8ca4d8d6db123f83f0f839 --md
Compiling project (Scala 3.2.0, JVM)
Compiled project (Scala 3.2.0, JVM)
Hello

@Gedochao
NIT refactor Elements & Inputs
cbbcd87 
  - adjust Elements traits' structure
  - some minor syntax fixes
  - extract Virtual elements' creation to a relevant `apply` method
@Gedochao Gedochao mentioned this pull request Nov 15, 2022
Merged
wleczny
wleczny approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@wleczny wleczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 63dc747 into VirtusLab:main Nov 15, 2022
@Gedochao Gedochao deleted the run-zip-with-md branch November 15, 2022 14:45
@Gedochao Gedochao added the enhancement New feature or request label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wleczny wleczny wleczny approved these changes

@lwronski lwronski Awaiting requested review from lwronski

@alexarchambault alexarchambault Awaiting requested review from alexarchambault

Assignees
No one assigned
Labels
enhancement New feature or request markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support running markdown files inside of zipped archives
2 participants
@Gedochao @wleczny