Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better revolver output #1614

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault alexarchambault changed the title Better revolver input Better revolver output Nov 28, 2022
@alexarchambault alexarchambault marked this pull request as draft November 28, 2022 16:08
@alexarchambault alexarchambault marked this pull request as ready for review November 29, 2022 13:15
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

def printWatchMessage(): Unit =
System.err.println(waitMessage("Watching sources"))

def waitForCtrlC(onPressEnter: () => Unit = () => ()): Unit = {
def printWatchWhileRunningMessage(): Unit =
System.err.println(gray("Watching sources while your program is running."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT I'm thinking the logger could be passed here and used to print the watch messages, to respect verbosity...
But it's not a big deal, can be done separately.

@alexarchambault alexarchambault merged commit ad57ee0 into VirtusLab:main Nov 29, 2022
@alexarchambault alexarchambault deleted the better-revolver-input branch November 29, 2022 14:54
@Gedochao Gedochao added the enhancement New feature or request label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants