Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalaCompilerPlugins to Mill project export #1626

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

carlosedp
Copy link
Contributor

@carlosedp carlosedp commented Nov 30, 2022

This PR adds the export of scala compiler plugins to Mill projects.

A file like:

//> using scala "2.13.10"
//> using lib "edu.berkeley.cs::chisel3::3.5.5"
//> using plugin "edu.berkeley.cs:::chisel3-plugin::3.5.5"

import chisel3._
import circt.stage.ChiselStage
...

Generates a build.sc:

import mill._
import mill.scalalib._

object memmask extends ScalaModule {
  def scalaVersion = "2.13.10"
  
  def ivyDeps = super.ivyDeps() ++ Seq(
  ivy"edu.berkeley.cs::chisel3::3.5.5",
)

  def scalacPluginIvyDeps = super.scalacPluginIvyDeps() ++ Seq(
  ivy"edu.berkeley.cs:::chisel3-plugin::3.5.5"
)
...

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@lwronski lwronski merged commit 55210e9 into VirtusLab:main Dec 2, 2022
@Gedochao Gedochao added the enhancement New feature or request label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants