Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting of generated Mill project #1677

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Improve formatting of generated Mill project #1677

merged 3 commits into from
Dec 27, 2022

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Dec 11, 2022

Before this PR:
Before
After this PR:
After

@lwronski
Copy link
Contributor

Hi @lolgab First of all, I would like to thank you for your contribution, it would be great to merge your changes.

Maybe you need some help to finish this PR?

@lolgab
Copy link
Contributor Author

lolgab commented Dec 23, 2022

Hi @lwronski,
I moved to other things and forgot about this PR, good that you asked.
I fixed the failing test, let's see if everything passes now :)

@lolgab
Copy link
Contributor Author

lolgab commented Dec 23, 2022

@lwronski the test that's failing seems flaky. Do you want to retry the failing step?

@lwronski
Copy link
Contributor

@lwronski the test that's failing seems flaky. Do you want to retry the failing step?

Done.

@lolgab lolgab marked this pull request as ready for review December 23, 2022 14:58
lwronski
lwronski approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contribution.

@lwronski lwronski merged commit 7108034 into VirtusLab:main Dec 27, 2022
@lolgab lolgab deleted the format-mill-project branch December 27, 2022 13:12
@Gedochao Gedochao added the enhancement New feature or request label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lolgab @lwronski @Gedochao