Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scalafmt Cookbook #2903

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

sierikov
Copy link
Contributor

@sierikov sierikov commented May 11, 2024

Adds Format Cookbook about built-in abilities to format code using scala-cli with scalafmt. Closes #333.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution! And sorry for the late review.
I suggested some tweaks in the comments.
The CI is also failing, see the comments for a hint to how to fix it.

website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
website/docs/cookbooks/introduction/formatting.md Outdated Show resolved Hide resolved
@Gedochao Gedochao linked an issue May 14, 2024 that may be closed by this pull request
@sierikov sierikov force-pushed the feature/333-cookbook-fmt branch 2 times, most recently from 493866c to 3f79419 Compare May 14, 2024 14:00
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sclicheck.DocTests.cookbook introduction/instant-startup-scala-scripts is failing, which is an external problem that got fixed in #2905 (cherry pick to stable in #2909)

That should go away after a rebase off stable.

We just need to fix sclicheck.DocTests.cookbook introduction/formattingand we're good to go.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Gedochao Gedochao merged commit a900a1b into VirtusLab:stable May 16, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookbook: formatting the code
2 participants